Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spacing when generating field-like structures #193

Merged
merged 2 commits into from
May 17, 2024

Conversation

jeparlefrancais
Copy link
Contributor

@jeparlefrancais jeparlefrancais commented May 16, 2024

Closes #185

This removes the space when generating field expressions, function statements (like Table0.fun) and types using namespaces.

  • add entry to the changelog

Copy link

Coverage after merging fix-generator-field-spacing into main will be

85.87%

Coverage Report for Changed Files
FileStmtsBranchesFuncsLinesUncovered Lines
src/generator
   dense.rs87.21%100%92.31%86.73%1012–1018, 1035–1039, 1047, 1056–1057, 1062, 1068, 1077–1085, 1087–1093, 1095–1103, 1108, 1117, 1129–1132, 1136–1139, 159–160, 162, 176–177, 179, 253–265, 267–273, 275–276, 287–289, 368, 417, 50, 507, 51–55, 57–59, 61, 614–616, 62–63, 65–68, 685, 69, 704, 75–76, 80, 897, 942, 959, 986–993
   mod.rs98.68%100%100%98.59%354, 370, 374
   readable.rs97.37%100%99.03%97.23%1122, 1173–1177, 1229, 1326, 1336, 1345, 1354, 1363, 180, 185–186, 190, 203–204, 209, 214, 232–233, 413, 46–51, 53, 655–656
   token_based.rs91.41%100%94.09%91.16%1001–1002, 1016–1018, 1032–1034, 1043–1045, 1054–1056, 1065–1067, 1117–1121, 113, 1276, 130–131, 1346, 1383–1391, 1467–1469, 147, 1470–1476, 148, 1501–1503, 1505–1507, 1524–1533, 1577, 160–161, 1635, 182–183, 203, 2032, 204–205, 2091–2092, 2118–2122, 2151–2155, 2162–2166, 2375, 2379, 2392, 245, 297–301, 371–372, 378, 390, 450–451, 473–474, 490–491, 533, 621–622, 655–656, 724–725, 766–767, 80, 808–812, 830–831, 84, 904–905, 914–915, 922, 937, 942–946, 965–966, 979–980

@jeparlefrancais jeparlefrancais merged commit a76494e into main May 17, 2024
6 checks passed
@jeparlefrancais jeparlefrancais deleted the fix-generator-field-spacing branch May 17, 2024 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"dense" and "readable" generators add a space after field parts that end in a number
1 participant