Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make assertEquals declarations compatible #30

Closed
wants to merge 1 commit into from
Closed

Make assertEquals declarations compatible #30

wants to merge 1 commit into from
+9 −9

Conversation

rlerdorf
Copy link
Contributor

Fix phpunit incompatible declaration errors

@rlerdorf
Make assertEquals declarations compatible

Verified

This commit was created on github.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
f4ec922
@rlerdorf rlerdorf mentioned this pull request Jan 29, 2017
Closed
@sebastianbergmann sebastianbergmann self-assigned this Jan 29, 2017
@sebastianbergmann
Copy link
Owner

Merged manually, thanks.

@sebastianbergmann sebastianbergmann mentioned this pull request Jan 29, 2017
Closed
@jrfnl jrfnl mentioned this pull request Jan 30, 2017
Merged
@szepeviktor szepeviktor mentioned this pull request Jan 30, 2017
Closed
@szepeviktor
Copy link

@sebastianbergmann It was reverted in 7c39195

When do you plan to support current PHP nightly?

@szepeviktor szepeviktor mentioned this pull request Feb 2, 2017
Closed
nafigator added a commit to nafigator/Veles that referenced this pull request Apr 23, 2017
@nafigator
Workaround for phpunit bug sebastianbergmann/comparator#30
65759bf
aritomelo added a commit to openeuropa/task-runner that referenced this pull request Sep 7, 2018
@aritomelo
OPENEUROPA-776: Update phpunit and http_build_url.
234db58 
    - The php version has been updated from 5.0 to 6.0, which introduce the namespacing and it is compatible with php7.2.
    The reason can be found [here](sebastianbergmann/comparator#30) and the solution [here](https://github.com/costlocker/reports/commit/f1e8aca4d7f26d4e2851a080ce6032dd47e4edab)

    - However it was tested the >=5.5 which is compatible with phpunit6.0 but not compatible with php 7.2 as mention above.

    - The http_build_url has been update due to this/https://github.com/jakeasmi    th/http_build_url/commit/14e42cc955a314986b788adc3fbae09f77927261 which was introduced on version 1.0.1.
    The version has been update from 1.0.0 to 1.0.1.
aritomelo added a commit to openeuropa/task-runner that referenced this pull request Sep 7, 2018
@aritomelo
OPENEUROPA-776: Update phpunit and http_build_url.
f2b109d 
    - The php version has been updated from 5.0 to 6.0, which introduce the namespacing and it is compatible with php7.2.
    The reason can be found [here](sebastianbergmann/comparator#30) and the solution [here](https://github.com/costlocker/reports/commit/f1e8aca4d7f26d4e2851a080ce6032dd47e4edab)

    - However it was tested the >=5.5 which is compatible with phpunit6.0 but not compatible with php 7.2 as mention above.

    - The http_build_url has been update due to this/https://github.com/jakeasmi    th/http_build_url/commit/14e42cc955a314986b788adc3fbae09f77927261 which was introduced on version 1.0.1.
    The version has been update from 1.0.0 to 1.0.1.
voidtek pushed a commit to openeuropa/task-runner that referenced this pull request Sep 10, 2018
@aritomelo @voidtek
OPENEUROPA-776: Update phpunit and http_build_url.
4d1325b 
    - The php version has been updated from 5.0 to 6.0, which introduce the namespacing and it is compatible with php7.2.
    The reason can be found [here](sebastianbergmann/comparator#30) and the solution [here](https://github.com/costlocker/reports/commit/f1e8aca4d7f26d4e2851a080ce6032dd47e4edab)

    - However it was tested the >=5.5 which is compatible with phpunit6.0 but not compatible with php 7.2 as mention above.

    - The http_build_url has been update due to this/https://github.com/jakeasmi    th/http_build_url/commit/14e42cc955a314986b788adc3fbae09f77927261 which was introduced on version 1.0.1.
    The version has been update from 1.0.0 to 1.0.1.
dxvargas pushed a commit to openeuropa/task-runner that referenced this pull request Sep 14, 2018
@aritomelo
OPENEUROPA-776: Make sure component dependencies are as relaxed as po…
574afa4 
…ssible (#76)

* OPENEUROPA-776: update consolidation robo from 1.2.2 to 1.2.0 with caret so sticks closer to semantic versioning, and allow non-breaking updates.

* OPENEUROPA-776: Added composer boundary to test lowest and highest version.

* OPENEUROPA-776: Update the pipeline, to define COMPOSER_BOUNDARY so the test can get fired on lowest and higest version within selected range.
  - composer-install-lowest:
  - composer-install-highest:
  - define constant COMPOSER_BOUNDARY
  - removed php 5.6 as it will be absolete shortly and our components requires >=7.1
  - added php7.2, so the components can be tested with higher versions too.

* OPENEUROPA-776:Fixed the yaml format.

* OPENEUROPA-776: testing alpha version on codereview.

* OPENEUROPA-776: testing phpunit 5.5 to check if it is compatible with code-review

*    OPENEUROPA-776: Update the robo to ^1.2.2.

   - The ISSUE, here/https://drone.fpfis.eu/openeuropa/task-runner/113/9

   - The FIXED, The minimum version has been fixed to 1.2.2.

   - Required method: Robo\Runner::setRelativePluginNamespace

   - The method was included here/consolidation/robo#671

   - Release tag 1.2.2/https://github.com/consolidation/Robo/blob/1.2.2/src/Runner.php#L517

* PENEUROPA-776: Update codereview to 6.0 minimum.

*  OPENEUROPA-776: Update phpunit and  http_build_url.

    - The php version has been updated from 5.0 to 6.0, which introduce the namespacing and it is compatible with php7.2.
    The reason can be found [here](sebastianbergmann/comparator#30) and the solution [here](https://github.com/costlocker/reports/commit/f1e8aca4d7f26d4e2851a080ce6032dd47e4edab)

    - However it was tested the >=5.5 which is compatible with phpunit6.0 but not compatible with php 7.2 as mention above.

    - The http_build_url has been update due to this/https://github.com/jakeasmi    th/http_build_url/commit/14e42cc955a314986b788adc3fbae09f77927261 which was introduced on version 1.0.1.
    The version has been update from 1.0.0 to 1.0.1.

* Revert "   OPENEUROPA-776: Update the robo to ^1.2.2."

This reverts commit ed0782d.

* OPENEUROPA-776: Update the consolidation/robo to ^1.2.2 on composer.json.

* OPENEUROPA-776: revert minimum php version on drone.

* OPENEUROPA-776: Optimize drone.yml.

* OPENEUROPA-775: Relax version constraints.

* OPENEUROPA-776: Relax version constraints.
jmccaffrey42 pushed a commit to jmccaffrey42/php-json-rpc that referenced this pull request Nov 23, 2018
Updated phpunit to 7.2.x
9a2638d 
* Tests would not run under PHP 7.2.12 because the signatures on some methods have changed and PHPUnit needs to be updated to fix this. sebastianbergmann/comparator#30
@jeherve jeherve mentioned this pull request Dec 18, 2018
Merged
@RentecJeremy RentecJeremy mentioned this pull request Jan 8, 2019
Closed
runelangseid added a commit to runelangseid/phpunit that referenced this pull request Jul 28, 2019
@runelangseid
PHP 7.2 compatibility - See sebastianbergmann/comparator#30
d092e1c
@jaylinski jaylinski mentioned this pull request Jan 8, 2020
Merged
@thewilkybarkid thewilkybarkid mentioned this pull request Feb 10, 2020
Merged
@ilario-pierbattista ilario-pierbattista mentioned this pull request Mar 20, 2021
Merged
SnakeCharm3r pushed a commit to SnakeCharm3r/comparator that referenced this pull request Dec 2, 2024
@sheby460
Merge pull request sebastianbergmann#30 from sheby460/chumaBranch
c0c6638 
drop down edit commit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sebastianbergmann sebastianbergmann

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rlerdorf @sebastianbergmann @szepeviktor