EKS support and testing #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ryan Cook <rcook@redhat.com>
cooktheryan
force-pushed
the
eks
branch
3 times, most recently
from
cdc9f30 to
b54efc7
Compare
Signed-off-by: Ryan Cook <rcook@redhat.com>
.github/workflows/main.yml
Outdated
| @@ -25,6 +26,22 @@ jobs: | |||
| with: | |||
| go-version: ${{ env.GO_VERSION }} | |||
|
|
|||
| - name: Build operator container | |||
| run: IMG=ttl.sh/securesign make docker-build docker-push | |||
There was a problem hiding this comment.
image should named to reflect the operator. Additionally TTLSH images are tagged with the time you wish the ephemeral image to exist, ex: ttl.sh/securesign/secure-sign-operator:1h
.github/workflows/main.yml
Outdated
| - name: Build and Deploy operator container | ||
| run: make docker-build docker-push deploy | ||
| - name: Deploy operator container | ||
| run: IMG=ttl.sh/securesign make deploy |
.github/workflows/main.yml
Outdated
| kubectl apply -f https://raw.githubusercontent.com/kubernetes/ingress-nginx/main/deploy/static/provider/aws/deploy.yaml | ||
|
|
||
| - name: Deploy operator container | ||
| run: IMG=ttl.sh/securesign make deploy |
.github/workflows/main.yml
Outdated
| - name: Deploy RTHAS | ||
| run: | | ||
| sed -i 's|"https://your-oidc-issuer-url"|${{ secrets.testing_keycloak }}|g' config/samples/rhtas_v1alpha1_securesign.yaml | ||
| sed -i 's|"trusted-artifact-signer"|"sigstore"|g' config/samples/rhtas_v1alpha1_securesign.yaml |
There was a problem hiding this comment.
This one produces multiple hits:
cat rhtas_v1alpha1_securesign.yaml| grep "trusted-artifact-signer"
app.kubernetes.io/part-of: trusted-artifact-signer
app.kubernetes.io/part-of: trusted-artifact-signer
I suggest using yq instead, or further restrict the sed command:
OIDC_ISSUER=https://$(oc get route keycloak -n keycloak-system | tail -n 1 | awk '{print $2}')/auth/realms/sigstore
OIDC_ISSUER="$OIDC_ISSUER" yq '.spec.fulcio.config.OIDCIssuers[strenv(OIDC_ISSUER)].ClientID = "sigstore" style="double"' -i config/samples/rhtas_v1alpha1_securesign.yaml
.github/workflows/main.yml
Outdated
|
|
||
| - name: delete the cluster | ||
| run: eksctl delete cluster --name rhtas-eks-${GITHUB_SHA} --region us-east-2 --wait | ||
| if: always() |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cooktheryan, Gregory-Pereira The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Beginning process of defining testing of EKS against main.