Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use SecurityContextConstraints resource to identify OCP environment #391

Merged
merged 1 commit into from
May 31, 2024

Conversation

osmman
Copy link
Contributor

@osmman osmman commented May 28, 2024

@osmman osmman requested review from bouskaJ and Gregory-Pereira May 28, 2024 10:20
@openshift-ci openshift-ci bot requested review from JasonPowr and lance May 28, 2024 10:20
@osmman osmman force-pushed the SECURESIGN-1002 branch 2 times, most recently from 32682e0 to ce4c260 Compare May 28, 2024 10:42
Copy link
Contributor

@Gregory-Pereira Gregory-Pereira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@osmman osmman force-pushed the SECURESIGN-1002 branch from ce4c260 to 131ebdc Compare May 29, 2024 14:36
@openshift-ci openshift-ci bot removed the lgtm label May 29, 2024
@osmman
Copy link
Contributor Author

osmman commented May 31, 2024

/cherrypick release-1.0

@openshift-cherrypick-robot

@osmman: once the present PR merges, I will cherry-pick it on top of release-1.0 in a new PR and assign it to you.

In response to this:

/cherrypick release-1.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Member

@lance lance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

I love how I learn new Go packages by just reviewing code. sync.Once is neat.

Copy link

openshift-ci bot commented May 31, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Gregory-Pereira, lance, osmman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Gregory-Pereira,lance,osmman]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 16ba548 into main May 31, 2024
11 checks passed
@openshift-cherrypick-robot

@osmman: new pull request created: #410

In response to this:

/cherrypick release-1.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants