Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SECURESIGN-574] Independently Deployable CT-log #561

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

tommyd450
Copy link
Contributor

After testing and signing and veryfying it should be up to scrath and working now.

To test you it is advised ctlog and trillian not be in the same namespace as the main change is to check that ctlog can successfully reach trillian elsewhere.

@tommyd450 tommyd450 requested a review from osmman August 19, 2024 13:41
Copy link
Contributor

@osmman osmman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

openshift-ci bot commented Aug 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: osmman, tommyd450

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@osmman
Copy link
Contributor

osmman commented Aug 19, 2024

please squash commits into single one

@tommyd450 tommyd450 force-pushed the tdalton/SECURESIGN-574 branch from 868581b to cf4c227 Compare August 20, 2024 10:37
@openshift-ci openshift-ci bot removed the lgtm label Aug 20, 2024
@tommyd450
Copy link
Contributor Author

/ok-to-test

@tommyd450
Copy link
Contributor Author

/test images

@tommyd450
Copy link
Contributor Author

/test tas-operator-e2e

@osmman
Copy link
Contributor

osmman commented Aug 20, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Aug 20, 2024
@osmman
Copy link
Contributor

osmman commented Aug 20, 2024

/override ci/prow/images
/override ci/prow/tas-operator-e2e

Copy link

openshift-ci bot commented Aug 20, 2024

@osmman: Overrode contexts on behalf of osmman: ci/prow/images, ci/prow/tas-operator-e2e

In response to this:

/override ci/prow/images
/override ci/prow/tas-operator-e2e

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@osmman osmman merged commit 6023656 into main Aug 21, 2024
12 of 14 checks passed
@osmman osmman deleted the tdalton/SECURESIGN-574 branch August 21, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants