Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update images, update fulcio config format #619

Merged
merged 5 commits into from
Sep 17, 2024
Merged

update images, update fulcio config format #619

merged 5 commits into from
Sep 17, 2024

Conversation

fghanmi
Copy link
Contributor

@fghanmi fghanmi commented Sep 16, 2024

fulcio configuration was updated in the latest versions (config.json -> config.yaml):
https://github.com/sigstore/fulcio/blob/main/pkg/config/config.go#L53-L119

Verified

This commit was signed with the committer’s verified signature.
osmman Tomas Turek
@openshift-ci openshift-ci bot requested review from bouskaJ and tommyd450 September 16, 2024 08:25
@fghanmi fghanmi changed the title update images update images, update fulcio config format Sep 17, 2024
@fghanmi fghanmi requested a review from osmman September 17, 2024 06:38
@osmman
Copy link
Collaborator

osmman commented Sep 17, 2024

please add unit tests for config action. You can use this as starting point 78e2b74

@fghanmi
Copy link
Contributor Author

fghanmi commented Sep 17, 2024

/test ci-index-securesign-bundle
/test images
/test tas-operator-e2e

Copy link

openshift-ci bot commented Sep 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fghanmi, osmman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fghanmi fghanmi merged commit 934268d into main Sep 17, 2024
15 checks passed
@osmman osmman deleted the RC2/update_images branch September 17, 2024 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants