Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hold job until depencies ready #22

Conversation

Gregory-Pereira
Copy link
Contributor

some basic docs and this script change should fix the issue where it couldnt query thanos.
/cc @lance

Copy link
Member

@lance lance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good - one teensy nit and one small change, please

@Gregory-Pereira Gregory-Pereira force-pushed the hold-job-until-depencies-ready branch 6 times, most recently from b30a29d to 740b2c0 Compare November 15, 2023 20:02
@Gregory-Pereira Gregory-Pereira force-pushed the hold-job-until-depencies-ready branch from 740b2c0 to 8395217 Compare November 15, 2023 20:24
@Gregory-Pereira Gregory-Pereira merged commit 4fda129 into securesign:master Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants