Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add-license-file #73

Merged
merged 1 commit into from
Mar 26, 2024
Merged

add-license-file #73

merged 1 commit into from
Mar 26, 2024

Conversation

JasonPowr
Copy link
Contributor

Add the license file to the image, similar to what need to be done for fbc images

Copy link
Contributor

@Gregory-Pereira Gregory-Pereira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

technically this will add the license twice but at this point its fine
/lgtm

@JasonPowr
Copy link
Contributor Author

I've remove the add, haha never coped that

@Gregory-Pereira
Copy link
Contributor

I mean if licenses was the right directory to go in I have no problem with adding it, even if its twice. I was regretting that I didnt have time to fix my lazy copy command

@JasonPowr
Copy link
Contributor Author

            {
                "name": "HasLicense",
                "elapsed_time": 0,
                "description": "Checking if terms and conditions applicable to the software including open source licensing information are present. The license must be at /licenses",
                "help": "Check HasLicense encountered an error. Please review the preflight.log file for more information.",
                "suggestion": "Create a directory named /licenses and include all relevant licensing and/or terms and conditions as text file(s) in that directory.",
                "knowledgebase_url": "https://access.redhat.com/documentation/en-us/red_hat_software_certification/8.63/html-single/red_hat_openshift_software_certification_policy_guide/index#assembly-requirements-for-container-images_openshift-sw-cert-policy-introduction",
                "check_url": "https://access.redhat.com/documentation/en-us/red_hat_software_certification/8.63/html-single/red_hat_openshift_software_certification_policy_guide/index#assembly-requirements-for-container-images_openshift-sw-cert-policy-introduction"
            }

licenses is the right directory, should be grand

@JasonPowr
Copy link
Contributor Author

Adding it back hah, didn't work for some reason even though it should have been in the same directory

@JasonPowr JasonPowr merged commit 7ea24b8 into main Mar 26, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants