Fix the select2 in the controlled vocab modal

seek4science · Jan 25, 2024 · 1cae556 · 1cae556
1 parent b657e2b
commit 1cae556
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 4 deletions.
diff --git a/app/assets/javascripts/controlled_vocabs.js.erb b/app/assets/javascripts/controlled_vocabs.js.erb
@@ -30,14 +30,20 @@ var SampleTypeControlledVocab = {
         initialise_rich_text_editors(".rich-text-edit");            
     },
 
+    copyBlankModalForm: function() {
+        // first destroy any select2 elements, which won't survive being cloned. They will be initialised again when reset
+        $j('#cv-modal select[data-role="seek-objectsinput"]').select2('destroy');
+        SampleTypeControlledVocab.blankControlledVocabModelForm=$j('#cv-modal').clone();
+    },
+
     //resets the modal
     resetModalControlledVocabForm: function () {
         $j('#cv-modal').remove();
         $j('#modal-dialogues').append(SampleTypeControlledVocab.blankControlledVocabModelForm.clone());
         CVTerms.init();
+        ObjectsInput.init();
         SampleTypeControlledVocab.bindNewControlledVocabShowEvent();
         SampleTypeControlledVocab.initialise_deferred_rich_editor_modal();
-
     },    
 
     //selected CV item changed

diff --git a/app/views/isa_studies/_sample_types_form.html.erb b/app/views/isa_studies/_sample_types_form.html.erb
@@ -80,7 +80,7 @@
 <script>
     //used to hold the element Id that needs updating after creating a new CV
     $j(document).ready(function () {
-        SampleTypeControlledVocab.blankControlledVocabModelForm=$j('#cv-modal').clone();
+        SampleTypeControlledVocab.copyBlankModalForm();
         SampleTypeControlledVocab.resetModalControlledVocabForm();
         // Make rows sortable
         SampleTypes.bindSortable("#<%=attribute_table_id%>");

diff --git a/app/views/sample_types/_form.html.erb b/app/views/sample_types/_form.html.erb
@@ -89,7 +89,7 @@
 <script>
     //used to hold the element Id that needs updating after creating a new CV
     $j(document).ready(function () {
-        SampleTypeControlledVocab.blankControlledVocabModelForm=$j('#cv-modal').clone();
+        SampleTypeControlledVocab.copyBlankModalForm();
         SampleTypeControlledVocab.resetModalControlledVocabForm();
         // Make rows sortable
         SampleTypes.bindSortable();

diff --git a/app/views/templates/_form.html.erb b/app/views/templates/_form.html.erb
@@ -104,7 +104,7 @@
 <script>
     //used to hold the element Id that needs updating after creating a new CV
     $j(document).ready(function() {
-        SampleTypeControlledVocab.blankControlledVocabModelForm = $j('#cv-modal').clone();
+        SampleTypeControlledVocab.copyBlankModalForm();
         SampleTypeControlledVocab.resetModalControlledVocabForm();
         //Make rows sortable
         SampleTypes.bindSortable();