Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spreadsheet extractor doesn't log error to stderr #1728

Closed
stuzart opened this issue Jan 30, 2024 · 1 comment
Closed

spreadsheet extractor doesn't log error to stderr #1728

stuzart opened this issue Jan 30, 2024 · 1 comment
Assignees
@stuzart
Milestone
v1.14.2

Comments

@stuzart
Copy link
Member

stuzart commented Jan 30, 2024

discovered with a spreadsheet that contains problems but is successfully parsed, but with error logs.

errors are being mixed in with the final result
@stuzart stuzart added this to the v1.15.0 milestone Jan 30, 2024
@stuzart
Copy link
Member Author

stuzart commented Jan 30, 2024

partially fixed, as the log4j config needed updating following the earlier security update to log4j2

however, terrapin hangs with a deadlock when the stderr buffer fills :(

there is apparently a merged PR which fixes it, but looks like it was merged to master instead of main - thoughtbot/terrapin#5

@stuzart stuzart self-assigned this Feb 1, 2024
stuzart added a commit that referenced this issue Feb 1, 2024
@stuzart
update simple-spreadsheet-extractor gem to fix #1728
acc9db7 
includes updated javacode, and error handling in the gem, to ensure any errors are logged to stderr rather than stdout, and therefore prevent uncritical errors appearing the successful output
@stuzart stuzart mentioned this issue Feb 1, 2024
Merged
@stuzart stuzart closed this as completed in 3b45e1f Feb 2, 2024
@stuzart stuzart modified the milestones: v1.15.0, v1.14.2 Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stuzart stuzart

Labels
None yet
Projects
SEEK 1.14.x
Status: Done
Milestone
v1.14.2
Development

No branches or pull requests
1 participant
@stuzart