Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dynamic table in default view #1725

Merged

Conversation

kdp-cloud
Copy link
Collaborator

Tiny bugfix for the dynamic table in default view:
The dynamic tables didn't render in default view because the instanceName variable was not declared in default view of a study or assay.

The variable instanceName in the javascript was moved to the window and declared in:

  • Single_pages/show
  • assay_design
  • study_design

@kdp-cloud kdp-cloud added bug datahub belgiumHub project labels Jan 19, 2024
@kdp-cloud kdp-cloud added this to the v1.15.0 milestone Jan 19, 2024
@kdp-cloud kdp-cloud self-assigned this Jan 19, 2024
@kdp-cloud kdp-cloud marked this pull request as ready for review January 19, 2024 09:30
@kdp-cloud kdp-cloud merged commit 3e0bc84 into seek4science:main Jan 24, 2024
@kdp-cloud kdp-cloud deleted the fix_dynamic_table_default_view branch January 24, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug datahub belgiumHub project
Projects
Status: Merged
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants