Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 1656 create an assay between two existing assays #1735

Merged
merged 33 commits into from
Feb 7, 2024
Merged

Issue 1656 create an assay between two existing assays #1735

merged 33 commits into from
Feb 7, 2024

Conversation

kdp-cloud
Copy link
Collaborator

  • Fix sample type linkage
  • Automates assay position

@kdp-cloud
Replace is_single_page_assay? by is_isa_json_compliant?
f994a36
@kdp-cloud
Add fix linkage to isa assays after a new one is created.
a1faa5d
@kdp-cloud
Order assays by position in assay_stream
f8c2200
@kdp-cloud
Create function to find the input attribute
3e0237b
@kdp-cloud
Add functions to find the next and previous linked sample type
8b5db61
@kdp-cloud
Simplify dynamic table helper
6b06477
@kdp-cloud
Fix sample type linkage when inserting new assays
ce06b7c
@kdp-cloud
Rearrange assay positions when inserting or deleting assays
69a4ef6
@kdp-cloud
Move code to private section
61c374f
@kdp-cloud
simplify assay linkage when deleting
bdd97c4
@kdp-cloud
Split functionality over assay and isa assay
af66b53
@kdp-cloud
Delete ST first, fix linkage later
e1c7903
@kdp-cloud
Simplify deletion of linked sampletypes in studies
f4b6783
@kdp-cloud
Fix existing assays controller tests
532c9f3
@kdp-cloud
Fix existing studies_controller tests
88c2053
@kdp-cloud
Correct sample type linkage
50dfe2a
@kdp-cloud
Fix existing tests
4a6c0eb
@kdp-cloud
Write test for inserting new assay between assay stream and first assay
8366b9e
@kdp-cloud
Write test for inserting an assay between two experimental assays
78c3a7e
@kdp-cloud
Actually better as a before_action since the sample_type is created b…
fc4c991 
…efore the assay
@kdp-cloud
Change the button text when inserting an assay between existing assays
d2d1a90
@kdp-cloud
Modify existing tests for inserting assays
3f75302
@kdp-cloud
Disable button when inserting an assay before an assay with samples i…
183c8ed 
…n its sample type
@kdp-cloud
Add test for disabled button
a09434b
@kdp-cloud
Test prevent inserting new assay if next assay's sample type has samples
518b8ce
@kdp-cloud
do not rearrange position if not isa json compliant or if assay stream
d8aec7d
@kdp-cloud
Fix tests
735896e
@kdp-cloud
test assay position after deletion
1ef73ff
@kdp-cloud
Order assay streams by position
e255e68
@kdp-cloud
Test positions after creating intermediate assays
d9c8af5
@kdp-cloud kdp-cloud requested a review from stuzart February 2, 2024 12:57
@kdp-cloud kdp-cloud marked this pull request as ready for review February 2, 2024 12:57
@kdp-cloud kdp-cloud self-assigned this Feb 2, 2024
@kdp-cloud kdp-cloud added the datahub belgiumHub project label Feb 2, 2024
@kdp-cloud kdp-cloud added this to the v1.15.0 milestone Feb 2, 2024
@kdp-cloud kdp-cloud linked an issue Feb 2, 2024 that may be closed by this pull request
Create an assay between two existing assays #1656
Closed
@kdp-cloud kdp-cloud merged commit d839fb1 into seek4science:main Feb 7, 2024
11 checks passed
@kdp-cloud kdp-cloud deleted the issue_1656_create_an_assay_between_two_existing_assays branch February 28, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stuzart stuzart stuzart approved these changes

Assignees

@kdp-cloud kdp-cloud

Labels
datahub belgiumHub project
Projects
SEEK 1.15.x
Status: Done
Milestone
v1.15.0
Development

Successfully merging this pull request may close these issues.

Create an assay between two existing assays
2 participants
@kdp-cloud @stuzart