Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix batch upload dynamic table #1763

Merged

Conversation

kdp-cloud
Copy link
Collaborator

@kdp-cloud kdp-cloud commented Feb 23, 2024

Fixes #1762:

  • JS Alert displaying error messages when HTTP requests fail
  • Change the field from status to sampleUploadAction so it doesn't make the requests fail when the Sample Type contains an attribute called status.

@kdp-cloud kdp-cloud added bug datahub belgiumHub project labels Feb 23, 2024
@kdp-cloud kdp-cloud added this to the v1.15.0 milestone Feb 23, 2024
@kdp-cloud kdp-cloud self-assigned this Feb 23, 2024
@kdp-cloud kdp-cloud marked this pull request as ready for review February 26, 2024 14:19
@kdp-cloud kdp-cloud merged commit 52b9721 into seek4science:main Feb 28, 2024
11 checks passed
@kdp-cloud kdp-cloud deleted the fix_batch_upload_dynamic_table branch February 28, 2024 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug datahub belgiumHub project
Projects
Status: Merged
Status: Done
Development

Successfully merging this pull request may close these issues.

Batch upload by spreadsheet fails silently
2 participants