Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify the pure CDP Mode API #3571

Closed
mdmintz opened this issue Feb 26, 2025 · 1 comment · Fixed by #3573
Closed

Simplify the pure CDP Mode API #3571

mdmintz opened this issue Feb 26, 2025 · 1 comment · Fixed by #3573
Assignees
Labels
enhancement Making things better UC Mode / CDP Mode Undetected Chromedriver Mode / CDP Mode

Comments

@mdmintz
Copy link
Member

mdmintz commented Feb 26, 2025

Simplify the pure CDP Mode API

Currently, pure CDP Mode may look something like the code shown below.
(Pure CDP Mode is CDP Mode without UC Mode, meaning no Selenium at all.)

import asyncio
from seleniumbase.core import sb_cdp
from seleniumbase.undetected import cdp_driver

url = "https://seleniumbase.io/demo_page"
loop = asyncio.new_event_loop()
driver = cdp_driver.cdp_util.start_sync(guest=True)
page = loop.run_until_complete(driver.get(url))
sb = sb_cdp.CDPMethods(loop, page, driver)
sb.type("textarea", "Some text")
sb.click("button")

With the changes coming in #3567 (already on my local machine), that only simplifies the imports a bit:

import asyncio
from seleniumbase import sb_cdp
from seleniumbase import cdp_driver

url = "https://seleniumbase.io/demo_page"
loop = asyncio.new_event_loop()
driver = cdp_driver.start_sync(guest=True)
page = loop.run_until_complete(driver.get(url))
sb = sb_cdp.CDPMethods(loop, page, driver)
sb.type("textarea", "Some text")
sb.click("button")

I want to simplify it much more, to maybe something like this:

from seleniumbase import sb_cdp

url = "https://seleniumbase.io/demo_page"
sb = sb_cdp.Chrome(url, guest=True)
sb.type("textarea", "Some text")
sb.click("button")
@mdmintz mdmintz added enhancement Making things better UC Mode / CDP Mode Undetected Chromedriver Mode / CDP Mode labels Feb 26, 2025
@mdmintz mdmintz self-assigned this Feb 26, 2025
@mdmintz
Copy link
Member Author

mdmintz commented Feb 26, 2025

This was resolved in 4.35.2 - https://github.com/seleniumbase/SeleniumBase/releases/tag/v4.35.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Making things better UC Mode / CDP Mode Undetected Chromedriver Mode / CDP Mode
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant