Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify CDP Mode examples #3572

Closed
mdmintz opened this issue Feb 26, 2025 · 1 comment · Fixed by #3573
Closed

Simplify CDP Mode examples #3572

mdmintz opened this issue Feb 26, 2025 · 1 comment · Fixed by #3573
Assignees
@mdmintz
Labels
tests This involves test updates or new tests UC Mode / CDP Mode Undetected Chromedriver Mode / CDP Mode

Comments

@mdmintz
Copy link
Member

mdmintz commented Feb 26, 2025

Simplify CDP Mode examples

It's time to simplify a lot of examples! Thanks to #3571 and earlier tickets, there's probably a lot of examples that can be simplified a bit. In some cases, updates may be very small (eg. replacing locale_code with locale), but with others (specifically ones using the pure SB CDP API) there are some big simplifications that can be made.
@mdmintz mdmintz added tests This involves test updates or new tests UC Mode / CDP Mode Undetected Chromedriver Mode / CDP Mode labels Feb 26, 2025
@mdmintz mdmintz self-assigned this Feb 26, 2025
@mdmintz mdmintz mentioned this issue Feb 26, 2025
Merged
@mdmintz
Copy link
Member Author

mdmintz commented Feb 26, 2025

This was resolved in 4.35.2 - https://github.com/seleniumbase/SeleniumBase/releases/tag/v4.35.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mdmintz mdmintz

Labels
tests This involves test updates or new tests UC Mode / CDP Mode Undetected Chromedriver Mode / CDP Mode
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

CDP Mode: Patch 38 seleniumbase/SeleniumBase
1 participant
@mdmintz