-
-
Notifications
You must be signed in to change notification settings - Fork 803
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build script that does nothing #1259
Conversation
After releasing this I would like to give people a week to complain before we start using this to enable any observable behavior. |
Would it be overkill to use the rustc_version crate? Good idea on the slow rollout. We could probably publish an rc version first when we try out an actual feature. |
The rustc_version crate adds 2.5 CPU-seconds of compile time on my computer above what this build script adds, which seemed excessive. We don't need a production quality semver parser or complete rustc metadata handling. |
Eventually we will want a build script that enables Serde impls for i128 and u128. As a first step here is a build script that does nothing to see whether we can roll this out without breaking anyone's workflow, without having a supported feature at stake in the event that it needs to be rolled back.
FYI there is also the |
Nice, I hadn't seen |
Thanks for demonstrating the implementation with version_check! In my own applications I would definitely use it. But for Serde I am going to stick with some simple parsing in the build script. I believe one of the defining challenges for Serde over the next few years will be avoiding bloat (or the perception of bloat) and there is a vast difference in perception between having dependencies and having no dependencies. I took a look at |
Eventually we will want a build script that enables Serde impls for i128 and u128 -- #1136. As a first step here is a build script that does nothing to see whether we can roll this out without breaking anyone's workflow, without having a supported feature at stake in the event that it needs to be rolled back.