Skip to content
This repository was archived by the owner on May 26, 2019. It is now read-only.

Correct import syntax documentation #6

Merged
merged 2 commits into from
Dec 20, 2016

Conversation

sowiecki
Copy link
Contributor

ImportExportMonitor is not exported as the default export, so importing per the current documentation actually leads to an undefined variable. This PR updates the Readme to reflect the correct way to import ImportExportMonitor.

Alternatively,index.js could be updated to:

import ImportExportMonitor from './ImportExportMonitor';
export default ImportExportMonitor;

Which would make import ImportExportMonitor from 'redux-import-export-monitor'; work as expected.

@oshikryu
Copy link
Contributor

👍

@calesce
Copy link
Collaborator

calesce commented Dec 20, 2016

I think I'd prefer that we make it the default export, want to change the PR to reflect that?

@drosen0
Copy link

drosen0 commented Dec 20, 2016

Wouldn't this be a breaking change? It should probably export both.

@calesce
Copy link
Collaborator

calesce commented Dec 20, 2016

@drosen0 we're still pre-1.0 😉

@calesce calesce merged commit dece51c into sergey-lapin:master Dec 20, 2016
@calesce
Copy link
Collaborator

calesce commented Dec 20, 2016

I'll release this and #7 as 1.0, I don't anticipate many more changes to the API in the near future.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants