Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix vulnerabilities and update other dependencies that don't break tests #176

Merged
merged 4 commits into from
Aug 29, 2019
Merged

Fix vulnerabilities and update other dependencies that don't break tests #176

merged 4 commits into from
Aug 29, 2019

Conversation

malob
Copy link
Contributor

@malob malob commented Jul 19, 2019

(Fixes #175)

NPM reports multiple vulnerabilities, and many packages where pretty old in general. Did the following:

  • Ran npm audit fix --force, then npm test to ensure all tests still passed (commit 8e97a1d).
  • Ran npm up, then npm test to ensure all test still passed (commit c2dd2c8).
  • Ran npm outdated and manually updated all packages to latest that didn't break test or change eslint output (commit 5d8f2ce).

Only package that broke tests when manually updated was async. Didn't update eslint related packages since they caused npx eslint . to report errors it wasn't reporting before.

Tested plugin with personal serverless project and everything seems to be working as expected.

@malob
Copy link
Contributor Author

malob commented Aug 3, 2019

@pmuens, anything I can do to help get this merge?

@malob malob closed this Aug 3, 2019
@malob malob reopened this Aug 3, 2019
@jwkicklighter
Copy link

@pmuens What needs to be done to merge this?

Copy link
Contributor

@pmuens pmuens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @malob thanks a lot for working on this fix 👍

I just checked out your branch and did a test deployment. Everything works as expected. Will merge this PR and do a new release in the upcoming hour(s).

LGTM :shipit:

@pmuens pmuens merged commit 2e50aed into serverless:master Aug 29, 2019
@malob malob deleted the fix-vulnerabilities branch August 29, 2019 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vulnerable version of googleapis
3 participants