Migration Issue fix for Google API v1beta to v1 #206
Conversation
remove unsupported property location close issue serverless#202: serverless#202
remove yarn.lock close issue serverless#202: serverless#202
Create gcf_migration_from_v1beta2_to_v1.md
bao1018
changed the title
|
@medikoo thanks for your patience, this is the fully tested version, you can use your proposed process to publish the new release. thanks
|
There was a problem hiding this comment.
@bao1018 Great thanks, it looks great. Still I think we still need to fix v2 (do not leave it broken) therefore I think steps should be following:
- Prepare revert of Migrate to CloudFunctions v1 API. #165 PR (you can easily create such PR, by visiting this PR and clicking "Revert") and merge it to master
- Prepare v2.4.3 release PR (please get familiar with https://github.com/serverless/serverless-google-cloudfunctions/blob/master/RELEASE_PROCESS.md) and merge (after merge v2.4.3 will be automatically released)
- Update this PR to also have changes that were proposed in Migrate to CloudFunctions v1 API. #165 (but do not bump release, just in commit message indicate it's a BREAKING CHANGE)
- Upgrade of
googleapis(we're not using latest version here), and drop of support for Node.js v6 (another BREAKING CHANGE commit). - Prepare v3.0.0 release PR (after merge v3.0.0 will be automatically published)
If you need help with anything, let me know
package.json
Outdated
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "serverless-google-cloudfunctions", | |||
| "version": "2.4.2", | |||
| "version": "3.0.0", | |||
There was a problem hiding this comment.
This should done with dedicated release PR. Please get familiar with https://github.com/serverless/serverless-google-cloudfunctions/blob/master/RELEASE_PROCESS.md
|
@zxhaaa6 can you address medikoo comments as soon as possible ? thanks |
|
@bao1018 sure, thanks |
|
Hi @medikoo, could you please help to review? And after that, I would prepare v3.0.0 release PR. Many thanks! |
There was a problem hiding this comment.
Great thanks @zxhaaa6 !
Either this work should be split into two PR's as follows:
- Change that was proposed with Migrate to CloudFunctions v1 API. #165
- Upgrade of
googleapis(so drop of support for Node.js)
Or it can stay in one PR, but then change should be proposed with two distinct (rebased on master, with no merge commit) and well described commits, with messages that follow Commit Message Guidelines.
Both ways are fine for me, so pick what feels better for you.
It's the only way to maintain history of repo clean, and to automatically produce a valid release
|
Oh sorry, I will split Upgrade of googleapis (so drop of support for Node.js) into another PR. Thanks @medikoo |
|
Hi @medikoo , could you please help to review? After that, I will do next step. Thanks! |
|
@medikoo , a strange travis issue |
Yes I saw, I've merged it as it didn't seem related to code changes |
couple of changes base on v2.4.2 this PR is going to fix below issue:#202