Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Improve CI for v2 #305

Merged
merged 4 commits into from
Aug 2, 2023
Merged

ci: Improve CI for v2 #305

merged 4 commits into from
Aug 2, 2023

Conversation

waywardmonkeys
Copy link
Contributor

These resulted in warnings in the GitHub Actions UI. The actions-rs actions haven't been maintained in some time.

These resulted in warnings in the GitHub Actions UI. The `actions-rs`
actions haven't been maintained in some time.
@waywardmonkeys waywardmonkeys changed the title ci: Update checkout and toolchain actions. ci: Improve CI for v2 Aug 2, 2023
Copy link
Collaborator

@mbrubeck mbrubeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@waywardmonkeys
Copy link
Contributor Author

That's odd. There's a binutils-dev on Ubuntu jammy, so not sure why this failed. (These packages were installed for running the fuzzer... which I'm not sure is an ideal thing to be doing in CI anyway.)

@waywardmonkeys
Copy link
Contributor Author

(And they installed fine for the checks running on the v1 branch...)

Can you re-trigger the build?

@mbrubeck
Copy link
Collaborator

mbrubeck commented Aug 2, 2023

#307 will fix the apt errors.

@waywardmonkeys
Copy link
Contributor Author

I'd just realized that as well and added a commit here that fixes that as well.

This feature no longer exists, so a test for it isn't needed.
This uses const_panic and other features which have ratcheted the
MSRV forward from what it was in v1.
@mbrubeck mbrubeck added this pull request to the merge queue Aug 2, 2023
Merged via the queue into servo:v2 with commit 76204d5 Aug 2, 2023
@waywardmonkeys waywardmonkeys deleted the improve-v2-ci branch August 2, 2023 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants