Remove unnecessary imports #134
Open
+1
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nico Burns <nico@nicoburns.com>
Signed-off-by: Nico Burns <nico@nicoburns.com>
Signed-off-by: Nico Burns <nico@nicoburns.com>
nicoburns
commented
Mar 10, 2025
Comment on lines
1232
to
-1234
| #[cfg(feature = "gecko")] | ||
| #[inline] | ||
| #[cfg(feature = "gecko")] |
There was a problem hiding this comment.
Note: duplicate attribute.
nicoburns
commented
Mar 10, 2025
| @@ -1949,7 +1949,6 @@ impl ComputedValues { | |||
|
|
|||
| /// Get the initial computed values. | |||
| pub fn initial_values_with_font_override(default_font: super::style_structs::Font) -> Arc<Self> { | |||
| use crate::logical_geometry::WritingMode; | |||
There was a problem hiding this comment.
Already imported at top of file
nicoburns
commented
Mar 10, 2025
| @@ -15,7 +15,7 @@ use crate::values::specified::{AllowQuirks, Integer, NonNegativeNumberOrPercenta | |||
| use crate::values::CustomIdent; | |||
| use cssparser::Parser; | |||
| use num_traits::FromPrimitive; | |||
| use std::fmt::{self, Debug, Write}; | |||
| use std::fmt::{self, Write}; | |||
There was a problem hiding this comment.
It is not necessary to import std::fmt::Debug just to use the derive macro.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These imports do not exist upstream so this helps to reduce the diff.