This repository was archived by the owner on Apr 9, 2024. It is now read-only.
Add icosahedron primitive #71
Merged
+83
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HenryWConklin
changed the title
HenryWConklin
force-pushed
the
even-more-primitives
branch
from
a2b34bb to
2a96483
Compare
setzer22
approved these changes
Nov 18, 2022
There was a problem hiding this comment.
Looks good! Thanks a lot 😄 Blackjack is missing one less primitive 👍
Your subdivision example reminds me that blackjack is missing Loop subdivision: https://en.wikipedia.org/wiki/Loop_subdivision_surface After one iteration of Loop subdivision, the icosahedron would become Blender's "icosphere" 🤔
Just a curiosity. In practice, if we want an icosphere primitive it's best to make it built-in, since subdivision is a slow operation.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #60