This repository was archived by the owner on Apr 9, 2024. It is now read-only.
Feature/sync #83
Merged
Feature/sync #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
setzer22
suggested changes
Feb 27, 2023
There was a problem hiding this comment.
Looks great. Thanks a lot for taking care of this! 😄
There's a couple minor comments to take care of. We should also document this feature so that people have a way to know about it. Maybe a top-level comment in blackjack_engine's lib.rs?
But other than that, this looks good 🙂, almost ready to merge!
PS: Oh, and take a look at the CI feedback, you need to address the clippy lints and make sure to run cargo fmt.
setzer22
approved these changes
Mar 1, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #80, allowing a feature flag to be used to conditionally compile HalfEdgeMesh to be Send + Sync when the sync feature is enabled.