Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare for upstream merge #53

Merged
merged 21 commits into from
Nov 11, 2023
Merged

Prepare for upstream merge #53

merged 21 commits into from
Nov 11, 2023

Conversation

shadow578
Copy link
Owner

@shadow578 shadow578 commented Nov 3, 2023 •
edited
Loading

prepares Marlin-H32 for upstream merge PR

Style / Docs changes

  • make naming more uniform across the source code and docs
  • update outdated comments and docs
  • revert changes outside the intended scope (e.g. README)
  • remove untested / unsupported HAL modules (e.g. dogm)
  • format code according to marlin code style

Code Changes

  • default to release build
  • use MinSerial (from postmortem debugging) for panic output

Depends on:

DDL: shadow578/framework-hc32f46x-ddl#6
Arduino: shadow578/framework-arduino-hc32f46x#7

Validation

Compile

  • pio
  • abm

Stability

  • ~5 min
  • ~1 hour
  • > 2 hour

Note

validation in release mode w/ POSTMORTEM_DEBUGGING and PANIC_ENABLE

@shadow578
rename HAL to HC32
edc931c 
- rename HAL/HC32F46x -> HAL/HC32
- rename pins/hc32f46x -> pins/hc32f460
- replace TARGET_HC32F46x -> ARDUINO_ARCH_HC32
- move HC32 board definition
- rename pio env
@shadow578
update source filters
3fd9edf
@shadow578
remove untested dogm HAL
3b8da35
@shadow578
update outdated documentation + function use
9e8618d
@shadow578
check for ARDUINO_ARCH_HC32 in HAL source files
230f8bb
@shadow578
update remaining TODO messages
549ddef
@shadow578
re-format HAL files
d9107b8
@shadow578
sort HAL includes
b053fec
@shadow578
add #pragma once
deae7c0
@shadow578
update #warning messages
43e11b6
@shadow578
update HAL README
0283b99
@shadow578
Revert "add #pragma once"
1666580 
This reverts commit deae7c0.
@shadow578
re-format hc32.ini
910fc00
@shadow578
undo unintended change to extensions.json
d006a6b
@shadow578
restore original README
5a90000 
- moves information to README for HAL
@shadow578
fix Servo not compiling correctly
fa0b917
@shadow578
default to release build
10bcbe3
@shadow578
update HC32 to use MinSerial for panic output
1153a99
@shadow578
fix panic output configuration for MinSerial
8f8b599
@shadow578 shadow578 changed the title Prep/fix codestyles Prepare for upstream merge Nov 9, 2023
@shadow578 shadow578 marked this pull request as ready for review November 9, 2023 10:56
This was linked to issues Nov 9, 2023
Plans to eventually get this back into mainline? #31
Closed
[BUG] Temperature auto-reporting (+ others) fail after ~72 Minutes #54
Closed
@shadow578
Copy link
Owner Author

Stability checks completed after millis() fix in Arduino core, total ~3h active time

@shadow578
Copy link
Owner Author

dependency PRs merged

@shadow578 shadow578 merged commit 0bb4c1b into aquila Nov 11, 2023
@shadow578 shadow578 deleted the prep/fix-codestyles branch November 11, 2023 13:44
@shadow578 shadow578 mentioned this pull request Nov 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@shadow578