Display Reference UDF Data #1026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shapiromatron
approved these changes
Jun 14, 2024
There was a problem hiding this comment.
Nice job, as always. I made a few minor edits, mostly stylistic. Ok to merge if you're ok with the changes. I did have one thought which was to add a few comments on complicated functions like _get_tag_binding_contents - I had to read it closely to see it did all the things that it needed to do; it'd be nice as a reader to be prompted of what it does.
|
And I fixed a regression in my changes 😅
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Display a reference's tag binding UDF data on the reference detail and reference search pages. The reference browse page requires changing API endpoints so it does not yet show reference UDF data
List view
List view expanded
Detail View
Detail view expanded
