Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve inline filter field #1128

Merged
merged 4 commits into from
Nov 4, 2024
Merged

Improve inline filter field #1128

merged 4 commits into from
Nov 4, 2024

Conversation

caseyhans
Copy link
Collaborator

  • Add animation to caret dropdown button
  • Add screen-reader friendly labels/help text to fields
  • Replace help text in 'title' with error message for appended fields

@caseyhans caseyhans requested review from rabstejnek and munnsmunns and removed request for rabstejnek October 30, 2024 18:03
munnsmunns
munnsmunns approved these changes Nov 4, 2024
View reviewed changes
Copy link
Collaborator

@munnsmunns munnsmunns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job!

shapiromatron
shapiromatron approved these changes Nov 4, 2024
View reviewed changes
Copy link
Owner

@shapiromatron shapiromatron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - I moved the sr information inside the appended fields main loop instead of a second pass - was that an ok change?

3472335

hawc/static/css/hawc.css
@@ -161,6 +161,13 @@ tfoot > tr > td {
.bg-light.clickable:active, .clickable:active .bg-light {
background-color: #d4d5d6 !important;
}
.collapsed .collapsible-icon {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i love it

hawc/apps/common/templates/common/crispy_layout_filter_field.html Outdated
@@ -40,6 +41,12 @@
<button type="submit" name="save" class="btn btn-primary px-5" title="Apply filters"><i class="fa fa-search" aria-hidden="true"></i></button>
</div>
</div>
{% for field in appended_fields %}
Copy link
Owner

@shapiromatron shapiromatron Nov 4, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I moved this inside the standard field div instead of adding another loop, is that ok? 3472335

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update, two commits:

  • 1e27d9c add back if statement, but add catch-all else (41 seconds ago) {Andy Shapiro}
  • 3472335 put in standard loop instead of multiple passes (24 minutes ago) {Andy Shapiro}

@shapiromatron shapiromatron merged commit 0240307 into main Nov 4, 2024
6 checks passed
@shapiromatron shapiromatron deleted the screen-reader-fields branch November 4, 2024 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shapiromatron shapiromatron shapiromatron approved these changes

@munnsmunns munnsmunns munnsmunns approved these changes

Assignees

@shapiromatron shapiromatron

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@caseyhans @shapiromatron @munnsmunns