Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set order for label displays (2) #1148

Merged
merged 1 commit into from
Dec 12, 2024
Merged

Set order for label displays (2) #1148

merged 1 commit into from
Dec 12, 2024

Conversation

rabstejnek
Copy link
Collaborator

Applies an order to labeled items based on the label path.

This applies the ordering at the model level, which I find less intrusive then the solution at #1140 .

@rabstejnek rabstejnek requested a review from caseyhans December 9, 2024 00:41
@shapiromatron shapiromatron mentioned this pull request Dec 9, 2024
Closed
caseyhans
caseyhans approved these changes Dec 12, 2024
View reviewed changes
Copy link
Collaborator

@caseyhans caseyhans left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great find, works for me! #1140 can be deleting pending final approval of this change

@caseyhans caseyhans assigned shapiromatron and unassigned caseyhans Dec 12, 2024
@shapiromatron shapiromatron merged commit f202181 into main Dec 12, 2024
6 checks passed
@shapiromatron shapiromatron deleted the order-label-displays-2 branch December 12, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caseyhans caseyhans caseyhans approved these changes

Assignees

@shapiromatron shapiromatron

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rabstejnek @caseyhans @shapiromatron