catch RIS import errors with form validation #647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shapiromatron
changed the title
caseyhans
approved these changes
Jul 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RIS files are messy and if improperly formatted, can lead to a bad import into HAWC. In most cases, our import form properly validates the RIS file and returns errors to the user. However, in a few edge cases (where a year is an empty string), the RIS passes validation, but then throws an error when we attempt to import references. This work properly tries to more strictly validate the file and pass exceptions to users.
We also did a little rewriting of tests, and standardized where the cleaning is done. Leaning on conventions with pydantic, our importer throws ValueError, and if found are caught by the form and cast as a ValidationError.