migrate integration tests to playwright #650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Nice! looking great, nice to see that net-negative in code :)
If it's working locally, but not in CI, I think you'll need to tweak the github actions file, we figured how how to run those tests in LLR if you need a reference
shapiromatron
approved these changes
Jul 21, 2022
There was a problem hiding this comment.
Really nice job. I made a few edits:
- rewrote the directly structure from
frontend/integrationtointegration, since they're really two separate things - update docs, specifically the
integration testsportion - used built-in fixture from pytest-playwright for setting up the playwright browser
|
@munnsmunns please merge if you're ok w/ my revisions! |
|
scratch that; broken in CI.... let me take a look |
|
ok, I think it's fixed, ok to merge @munnsmunns if you're happy... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement Playwright as our engine for integration tests, replacing selenium/helium. This will make it easier to write future tests, and it runs our current tests slightly faster than before.
Also adds the command
make test-integration-debug, which runs the integration tests in headed mode with a chrome window and a debugger.Performance impacts, around 70s vs 130s w/ selenium:
old:
new:
|