Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change Healthcheck path #669

Merged
merged 4 commits into from
Jul 25, 2022
Merged

Change Healthcheck path #669

merged 4 commits into from
Jul 25, 2022

Conversation

caseyhans
Copy link
Collaborator

@caseyhans caseyhans commented Jul 22, 2022 •
edited by shapiromatron
Loading

  • Moves the healthcheck out of the admin view so it's accessible regardless of firewall rules related to admin paths.
  • Added new configurable setting, HEALTHCHECK_URL_PREFIX, which can be configured via environment variable of the same name, to add a prefix to the location of healthchecks
  • Added these URLs to the SWAGGER API generated in admin

@caseyhans caseyhans requested a review from shapiromatron July 22, 2022 20:04
shapiromatron
shapiromatron approved these changes Jul 25, 2022
View reviewed changes
Copy link
Owner

@shapiromatron shapiromatron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I ended up fully qualifying the common URL path and API endpoints, just for consistency across the application.

@shapiromatron shapiromatron merged commit afeaba4 into main Jul 25, 2022
@shapiromatron shapiromatron deleted the change-healthcheck-path branch July 25, 2022 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shapiromatron shapiromatron shapiromatron approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@caseyhans @shapiromatron