Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quill validation on frontend components #699

Merged
merged 13 commits into from
Sep 21, 2022
Merged

Conversation

rabstejnek
Copy link
Collaborator

@rabstejnek rabstejnek commented Sep 14, 2022

Adds hyperlink validation and html cleaning to risk of bias score forms, visual forms, and summary text forms.

risk of bias scores

image

image

tagtree visual

image

data pivot visual

image

summary text

image

@rabstejnek rabstejnek changed the title WIP: Quill validation on frontend components Quill validation on frontend components Sep 15, 2022
@rabstejnek rabstejnek marked this pull request as ready for review September 15, 2022 20:56
Copy link
Owner

@shapiromatron shapiromatron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - @rabstejnek could you review this one additional change? e744a3e

This implements the validation logic in the bulk-cleaning views as well.

@rabstejnek
Copy link
Collaborator Author

@shapiromatron Bulk cleaning change looks good!

@rabstejnek rabstejnek merged commit 7e59715 into next Sep 21, 2022
@rabstejnek rabstejnek deleted the js-quill-validation branch September 21, 2022 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants