Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update /new/ endpoints to /create/ #707

Merged
merged 3 commits into from
Oct 24, 2022
Merged

update /new/ endpoints to /create/ #707

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b397d7e
update /new/ endpoints to /create/
munnsmunns Oct 19, 2022
56d8aeb
replace getBBox with getBoundingClientRect
munnsmunns Oct 20, 2022
da9886e
Merge branch 'main' into update-url-pattern
shapiromatron Oct 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions hawc/apps/animal/urls.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@
),
# Experiment
path(
"study/<int:pk>/experiment/new/",
"study/<int:pk>/experiment/create/",
views.ExperimentCreate.as_view(),
name="experiment_new",
),
Expand All @@ -75,7 +75,7 @@
),
# AnimalGroup
path(
"experiment/<int:pk>/animal-group/new/",
"experiment/<int:pk>/animal-group/create/",
views.AnimalGroupCreate.as_view(),
name="animal_group_new",
),
Expand Down Expand Up @@ -127,7 +127,7 @@
name="assessment_endpoint_taglist",
),
path(
"animal-group/<int:pk>/endpoint/new/",
"animal-group/<int:pk>/endpoint/create/",
views.EndpointCreate.as_view(),
name="endpoint_new",
),
Expand Down
6 changes: 3 additions & 3 deletions hawc/apps/lit/urls.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@
),
# CRUD searches
path(
"assessment/<int:pk>/search/new/",
"assessment/<int:pk>/search/create/",
views.SearchNew.as_view(),
name="search_new",
),
Expand Down Expand Up @@ -113,12 +113,12 @@
),
# CRUD import
path(
"assessment/<int:pk>/import/new/",
"assessment/<int:pk>/import/create/",
views.ImportNew.as_view(),
name="import_new",
),
path(
"assessment/<int:pk>/ris-import/new/",
"assessment/<int:pk>/ris-import/create/",
views.ImportRISNew.as_view(),
name="import_ris_new",
),
Expand Down
8 changes: 4 additions & 4 deletions hawc/apps/summary/urls.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,22 +110,22 @@
),
# DATA-PIVOT
path(
"data-pivot/assessment/<int:pk>/new/",
"data-pivot/assessment/<int:pk>/create/",
views.DataPivotNewPrompt.as_view(),
name="dp_new-prompt",
),
path(
"data-pivot/assessment/<int:pk>/new/query/",
"data-pivot/assessment/<int:pk>/create/query/",
views.DataPivotQueryNew.as_view(),
name="dp_new-query",
),
path(
"data-pivot/assessment/<int:pk>/new/file/",
"data-pivot/assessment/<int:pk>/create/file/",
views.DataPivotFileNew.as_view(),
name="dp_new-file",
),
path(
"data-pivot/assessment/<int:pk>/new/copy-as-new-selector/",
"data-pivot/assessment/<int:pk>/create/copy-as-new-selector/",
views.DataPivotCopyAsNewSelector.as_view(),
name="dp_copy_selector",
),
Expand Down
6 changes: 3 additions & 3 deletions tests/integration/test_bioassay.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ def test_write(self):
page.locator("text=Create new experiment").click()

# create experiment
expect(page).to_have_url(re.compile(r"/ani/study/\d+/experiment/new/"))
expect(page).to_have_url(re.compile(r"/ani/study/\d+/experiment/create/"))
page.locator('input[name="name"]').fill("test")
page.locator('select[name="type"]').select_option("Sb")
page.locator("text=Chemical purity available?").click()
Expand All @@ -62,7 +62,7 @@ def test_write(self):
page.locator("text=Actions").click()
page.locator("text=Create new").click()

expect(page).to_have_url(re.compile(r"/ani/experiment/\d+/animal-group/new/"))
expect(page).to_have_url(re.compile(r"/ani/experiment/\d+/animal-group/create/"))
page.locator('input[name="name"]').fill("test123")
page.locator('select[name="species"]').select_option("1")
page.locator('select[name="sex"]').select_option("M")
Expand Down Expand Up @@ -101,7 +101,7 @@ def test_write(self):
page.locator("text=Create new").click()

# create endpoint
expect(page).to_have_url(re.compile(r"/ani/animal-group/\d+/endpoint/new/"))
expect(page).to_have_url(re.compile(r"/ani/animal-group/\d+/endpoint/create/"))
page.locator('[placeholder="Enter term ID"]').fill("5")
page.locator("text=Load ID").click()
page.locator('input[name="response_units"]').fill("mg")
Expand Down