Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

risk of bias metric key field #771

Merged
merged 10 commits into from
Apr 4, 2023
Merged

risk of bias metric key field #771

merged 10 commits into from
Apr 4, 2023

Conversation

shapiromatron
Copy link
Owner

@shapiromatron shapiromatron commented Jan 19, 2023

Add a new risk of bias key field to match metrics across assessments. This way, we don't need to do fuzzy text-comparisons if metrics across assessments have the same key. The key is optional, and was not applied to existing data in HAWC.

image

Also reviewed the IRIS handbook and confirmed that all metrics in HAWC are consistent with the handbook.


Also created a jupyter notebook, hawc/scripts/client/rob-config.ipynb, which can be used to save study evaluation configuration to a JSON file compatible with our load approach method. This automated approach to generating the JSON changed some of the formatting in the documents, but we reviewed the underlying approaches to confirm they're consistent.

@shapiromatron shapiromatron marked this pull request as ready for review March 16, 2023 14:38
Copy link
Collaborator

@munnsmunns munnsmunns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@shapiromatron shapiromatron merged commit 160c7a0 into main Apr 4, 2023
@shapiromatron shapiromatron deleted the rob-keys branch April 4, 2023 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants