Conflict Resolution updates from review #774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caseyhans
changed the base branch from
main
to
literature-conflict-resolution
caseyhans
changed the title
caseyhans
changed the title
shapiromatron
approved these changes
Feb 28, 2023
There was a problem hiding this comment.
Great job! I'm really excited to merge these final few in!
I made a number of minor changes, the only larger one was moving some of the logic to get the parent tags which was sprinkled in the views to a class-method on the models.Reference model. I'm not sure that's ultimately where it belongs, but it's at least a little more DRY
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screening revisions from review: