Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User tagging export #789

Merged
merged 14 commits into from
Mar 8, 2023
Merged

Conversation

shapiromatron
Copy link
Owner

@shapiromatron shapiromatron commented Feb 23, 2023

Add downloadable exports for user tagging, and refine the implement for how we add reference tags.

Available on the /assessment/:id/downloads/ download page:

image


As part of adding the user-tag exports, we did some substantial API refactoring of literature reference exports. Previously, the same export function was called from three endpoints, depending on if a tag was selected, if a search was selected, or overall for an assessment. This has been modified to have a single route for downloading, and the ability to specify query parameters via django_filters to filter by search or tag.

Finally, we improved the speed of report generation optimizing the queryset for the models, as well as writing a new set-based method for determining if a parent tag should be marked True in the export as a result of a child tag being used.

@shapiromatron shapiromatron changed the base branch from main to literature-conflict-resolution February 23, 2023 21:57
@shapiromatron shapiromatron requested a review from caseyhans March 2, 2023 21:25
@shapiromatron shapiromatron marked this pull request as ready for review March 2, 2023 21:25
Copy link
Collaborator

@caseyhans caseyhans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hefty PR but it all looks good to me!

@shapiromatron shapiromatron merged commit 0062322 into literature-conflict-resolution Mar 8, 2023
@shapiromatron shapiromatron deleted the lit-export branch March 8, 2023 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants