Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only renders 'no data available' when user is a team member or higher #822

Merged
merged 7 commits into from
May 25, 2023

Conversation

dannypeterson
Copy link
Contributor

@dannypeterson dannypeterson commented May 3, 2023

We previously showed "none available" to the public for assessments if no data are available. This has been revised to only show no data available if you're able to edit content, otherwise, the header isn't shown.

If data is available for a given extraction domain, no changes is made; it's displayed in either case.

Unauthenticated Team Member
(empty)image image

@dannypeterson dannypeterson marked this pull request as ready for review May 4, 2023 13:46
Copy link
Owner

@shapiromatron shapiromatron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Back in your court @dannypeterson - I had to change things because with the initial implementation, even if there was data, it wasn't presented to the public unless a user had edit permission. I had to update the individual templates, many haven't been touched in years, so I ended up editing them a bit more to use some of the helper utilities we have in HAWC now...

@dannypeterson dannypeterson merged commit bfb056d into main May 25, 2023
@dannypeterson dannypeterson deleted the study-data-extractions branch May 25, 2023 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants