Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update assessment filtering #839

Merged
merged 9 commits into from
Jul 20, 2023
Merged

update assessment filtering #839

merged 9 commits into from
Jul 20, 2023

Conversation

caseyhans
Copy link
Collaborator

@caseyhans caseyhans commented Jun 1, 2023

Changes

Updates assessment lists to use the new inline filter forms, and to show more data in the table.

FilterSet updates:

  • BaseFilterset now allows for fields to specify an initial value; this is NOT recommended for the vast majority of filter options, but it is useful for order by, since a default/initial order is unavoidable. See django-filter docs for more info
  • 'Select' widget fields in the inline form now show help text when hovered over (if available)
    image

Public assessment list

Before

image

After

  • Inline filter form with increased filter capacity (name, author, year, assessment values, project type, report id, dtxsid, casrn)
  • CASRN shown in table, when available
  • Assessment objectives rendered as safe, allowing for formatting

image

Portal assessment list

Before

image

After

  • Same changes as public assessment list
  • Combined three separate lists based on assessment role into one list
  • Users can also filter by assessment role on this page (manager, team member, reviewer)

image

Copy link
Owner

@shapiromatron shapiromatron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - @casey1173 I ended up making a number of additional minor revisions, could you please give it one more pass through prior to merging to make sure things look ok?

@caseyhans caseyhans merged commit 5b85c28 into main Jul 20, 2023
@caseyhans caseyhans deleted the update-assessment-filtering branch July 20, 2023 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants