Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed float right from <ActionsButton /> #863

Merged
merged 7 commits into from
Jul 27, 2023
Merged

Conversation

dannypeterson
Copy link
Contributor

@dannypeterson dannypeterson commented Jul 26, 2023

  • removed class float right from actions button js component

@dannypeterson dannypeterson marked this pull request as ready for review July 26, 2023 18:03
Copy link
Owner

@shapiromatron shapiromatron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I only made one change to remove the default btn-primary since that is modified in some cases

<a className={`dropdown-toggle btn ${props.dropdownClasses}`} data-toggle="dropdown">
<div className={`dropdown btn-group ml-auto align-self-start ${props.containerClasses}`}>
<a
className={`btn btn-primary dropdown-toggle ${props.dropdownClasses}`}
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to remove the hard-coded btn-primary so that you could specify other classes w/ the dropdownClasses

@shapiromatron shapiromatron merged commit 45c682d into main Jul 27, 2023
@shapiromatron shapiromatron deleted the action-float-right-js branch July 27, 2023 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants