Endpoint Aggregation form #883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shapiromatron
requested review from
caseyhans
and removed request for
munnsmunns
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed:
Background: The visual Endpoint Aggregation type is deprecated and no longer used. However, we have existing ones in the database, so we need some sort of form to edit. This PR removes all JS related to this form, and then updates the django form so it's usable. I spent a little extra time updating how the queryset for the endpoint selector is returned; it seems like it may be useful in the future, and this pattern may be reusable in other contexts.
Examples to check:
/summary/assessment/100500032/visuals/0/create//summary/visual/assessment/100500032/cancer-data/