Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge tags #908

Merged
merged 13 commits into from
Oct 4, 2023
Merged

merge tags #908

merged 13 commits into from
Oct 4, 2023

Conversation

caseyhans
Copy link
Collaborator

@caseyhans caseyhans commented Sep 28, 2023

Adds a "Apply all tags below" option to the conflict resolution view. This merges all UserReferenceTags for a reference then applies the tags to the reference and the UserReferenceTag of the user making this change.

Unmerged
image

After merge
image

Updated "Approve All" button:

image

@caseyhans caseyhans marked this pull request as ready for review October 2, 2023 15:11
Copy link
Owner

@shapiromatron shapiromatron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - I made some edits to the flow and the button, so it says "Approve all" to be consistent with the current "Approve" buttons. I also added some help text to describe what happens when you press.

image
image

If you're happy with the flow and changes, ok to merge!

@caseyhans caseyhans merged commit 84ed266 into main Oct 4, 2023
@caseyhans caseyhans deleted the merge-tags branch October 4, 2023 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants