Custom filter logic helper #986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shapiromatron
approved these changes
Feb 8, 2024
There was a problem hiding this comment.
Great idea to use the parser output; I just edited what the query component looks like in 142a032, but didn't touch the logic:
(
(
"study id" ≥ 123 {1}
AND
"system" contains "hepatic" {2}
)
OR
"sex" contains "male" {3}
)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a helpful representation of a user's custom filter logic directly below their input on the exploratory heatmap forms.
It is indented and the grouping simplified in the representation, making it easier for a user to visually see what logic they have written. It also informs the user in real time if the logic string is non-parseable.