data pivot - add columns to the right of the figure #987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rabstejnek
approved these changes
Mar 12, 2024
There was a problem hiding this comment.
Looks good! I did notice some edge cases though that aren't rendering as you would expect; I'll leave it up to you if they need to be addressed before merging, they are relatively minor.
-
When text background is highlighted but not behind the plot, the columns on the right aren't highlighted.
-
When all columns are to the right and text background is highlighted, there is some leftover highlighting on the left of the plot.
shapiromatron
added a commit
that referenced
this pull request
Mar 14, 2024
rabstejnek
added a commit
that referenced
this pull request
Mar 14, 2024
* refactor vertical alignment * add calc columns * continue? * Revert "refactor vertical alignment" This reverts commit 29ad230. * add back header * add select manager * remove unused field_index * add calculated cols * add computed fields * fix db fixture * add a check stub * Added parser for custom format strings * Ternary operations in format parser * Updated tests * Linter * Update calculated columns * Update npm script name * Add tests, fix parser * fix migration conflict * use latest peggy version * add "to_right" to fixture; should have added in #987 * add round * fix test case * add some text to describe how to use * fix docs (facepalm) --------- Co-authored-by: Daniel Rabstejnek <rabstejnek@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new option to add content to the right of the plot in a data pivot.
Check an item "to right":
Related work in #991 adds calculated columns as a new option, to compose multiple columns in a dataset to a new column.