Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flush and rebuild vcr, replace pytest vcr with pytest recording #994

Merged
merged 11 commits into from
Feb 23, 2024

Conversation

dannypeterson
Copy link
Contributor

@dannypeterson dannypeterson commented Feb 15, 2024

Flushed and rebuilt VCR. pytest-vcr package is no longer supported, so replaced with pytest-recording. Removed urllib3 because it is a dependency of the requests package. A list of changes:

  • Updated requirements/dev.txt
  • Updated pyproject.toml
  • Updated github actions workflow
  • Deleted old cassettes and rebuilt with pytest recording, checked with wifi disabled

NOTE: this branch requires a few updates to the current dev environment:

python -m pip uninstall pytest-vcr
python -m pip install -U urllib3
python -m pip install -r requirements/dev.txt

Copy link
Owner

@shapiromatron shapiromatron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice job!

@shapiromatron shapiromatron merged commit a38ef8e into main Feb 23, 2024
3 checks passed
@shapiromatron shapiromatron deleted the replace-vcr-with-recording branch February 23, 2024 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants