Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganization proposal #115

Closed
leafac opened this issue Jan 26, 2021 · 4 comments
Closed

Reorganization proposal #115

leafac opened this issue Jan 26, 2021 · 4 comments
Labels

Comments

@leafac
Copy link
Member

leafac commented Jan 26, 2021

  1. Bring https://github.com/shikijs/shiki-latex into https://github.com/shikijs/shiki.
  2. Bring https://github.com/leafac/shiki-rehype into https://github.com/shikijs/shiki OR invite https://github.com/rsclarke/rehype-shiki into https://github.com/shikijs/shiki (depending on the outcome of Proposal: A different approach rsclarke/rehype-shiki#49).

/cc @octref @orta

@orta
Copy link
Contributor

orta commented Feb 2, 2021

I'm open to bringing both of these in - @rsclarke I'd love an opinion in rsclarke/rehype-shiki#49 too

@octref
Copy link
Collaborator

octref commented Apr 7, 2021

LGTM. Feel free to send the PRs.
What's the pros and cons of monorepo though? I haven't used it extensively to have an opiniong. I know it reduces manual linking you need to do, but it also makes repo larger and more complex.

@octref octref added the meta label Apr 7, 2021
@leafac
Copy link
Member Author

leafac commented Jun 13, 2021

I believe since @octref’s last comment we went with the monorepo approach, right? I see a packages/ directory in https://github.com/shikijs/shiki/

I’m checking in to let you know that I’m still around and I’ll get to this in the near future…

@octref
Copy link
Collaborator

octref commented Jun 19, 2021

@leafac Sure, let's go with the monorepo approach. I'll close this in favor of #58.

@octref octref closed this as completed Jun 19, 2021
antfu added a commit that referenced this issue Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants