Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add rel lang #287

Merged
merged 1 commit into from
Jan 31, 2022
Merged

feat: add rel lang #287

merged 1 commit into from
Jan 31, 2022

Conversation

robbear
Copy link
Contributor

@robbear robbear commented Jan 13, 2022

  • This PR fixes #
  • I have read docs for adding a language.
  • I have searched around and this is the most up-to-date, actively maintained version of the language grammar.
  • I have added a sample file that includes a variety of language syntaxes and succinctly captures the idiosyncrasy of a language. See docs for requirement.

@orta
Copy link
Contributor

orta commented Jan 31, 2022

Cool, looks good to me thanks

@orta orta merged commit e40647c into shikijs:main Jan 31, 2022
@octref
Copy link
Collaborator

octref commented Jan 31, 2022

LGTM as well. Thanks @orta for merging this.
@robbear Can you provide a link to an official website for rel lang and a link to its spec? I'm thinking that we should add those fields in ILanguageRegistration. I can't find your language by just googling rel lang.

@robbear
Copy link
Contributor Author

robbear commented Feb 1, 2022

@octref I can point you to https://docs.relational.ai and https://docs.relational.ai/rel/intro/overview/ for now. Should we want to update these links down the road, what would be the procedure? Thank you for the merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants