-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PHP loader: use phpstan includes
#35
Conversation
Thank you! I also added a test that ensures it truely works in #36 |
Released in 2.1.4 |
nice! |
i'm unsure it it's related to this change or not, but now if I run phpstan in a PR, with baseline errors fixed, I am getting an error for each error that I've removed from the baseline.
i am running it as suggested in the docs with https://github.com/phpstan/phpstan/blob/2.1.x/website/src/user-guide/result-cache.md?plain=1 |
that said i've only just starting using this library. so another option is that this PR does not work as intended. |
if you don't want this errors you should use https://phpstan.org/user-guide/ignoring-errors#reporting-unused-ignores |
no, the errors have been fixed and removed from the baseline, but phpstan thinks they are in the baseline. so I think this is a cache problem. |
I've cleared the github actions caches and it's resolved. so i'll see how it goes |
unfortunately this issue has reoccurred, every time baseline errors are removed. |
ignore all this. i worked out the problem. PEBCAK |
Using phpstan
includes
instead ofrequire
improves the cache handling.At the moment phpstan does not recognize changes in the baseline files (e.g. when removing/comment a baseline entry manually). It only recognizes changes to the loader file.