Add dorzel to OWNERS as Reviewer #1808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Promote Dylan Orzel (@dorzel) to `reviewer` in the shipwright-io/build repo, in recognition of his contributions related to scheduling builds on Kubernetes clusters. Many of these implement the API-level features described in SHIP-0039 [1]. Thank you Dylan for your efforts! [1] https://github.com/shipwright-io/community/blob/main/ships/0039-build-scheduler-opts.md Signed-off-by: Adam Kaplan <adam.kaplan@redhat.com>
pull-request-size
bot
added
the
size/XS
openshift-ci
bot
added
release-note-none
openshift-ci
bot
added
the
do-not-merge/invalid-owners-file
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: SaschaSchwarze0 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
Looks like I got the order backwards - we need to invite the person to the org before adding to the OWNERS file. Since there were no objections at the community meeting, and this PR has "approve", I have gone ahead and invited @dorzel to the shipwright-io org as a "Build Contributor". Once the invite is accepted we can re-verify the OWNERS file. |
|
/verify-owners |
openshift-ci
bot
removed
the
do-not-merge/invalid-owners-file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Promote Dylan Orzel (@dorzel) to
reviewerin the shipwright-io/build repo, in recognition of his contributions related to scheduling builds on Kubernetes clusters. Many of these implement the API-level features described in SHIP-0039 [1].Thank you Dylan for your efforts!
[1] https://github.com/shipwright-io/community/blob/main/ships/0039-build-scheduler-opts.md
/kind cleanup
Submitter Checklist
See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.
Release Notes