Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-v0.14] Backport CVE-2025-22869 changes to v0.14 from v0.15; Update go to 1.23.0 from 1.22.0 to support x/crypto 0.35 #1828

Closed

Conversation

psrvere
Copy link

@psrvere psrvere commented Mar 6, 2025

Changes

Backport #1755 to release-0.14. This PR

  • updates golang.org/x/crypto to 0.35 to address CVE-2025-22869
  • updates go to 1.23.0 from 1.22.0 to support golang.org/x/crypto 0.35 version

/kind dependency-change

Submitter Checklist

  • Includes tests if functionality changed/was added
  • Includes docs if changes are user-facing
  • Set a kind label on this PR
  • Release notes block has been filled in, or marked NONE

Release Notes

Update golang.org/x/crypto to v0.35.0 to address CVE-2025-22869. Update go to 1.23.0 from 1.22.0 to support x/crypto 0.35.

@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Label for when a PR has specified a release note kind/dependency-change Categorizes issue or PR as related to changing dependencies labels Mar 6, 2025
Copy link
Contributor

openshift-ci bot commented Mar 6, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign adambkaplan for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 6, 2025
@psrvere psrvere changed the title [release-v0.14] Backport CVE-2025-22869 changes to v0.14 from v0.15; Update go to 1.23.0 from 1.22.0 to support x/crypto 0.25 [release-v0.14] Backport CVE-2025-22869 changes to v0.14 from v0.15; Update go to 1.23.0 from 1.22.0 to support x/crypto 0.35 Mar 6, 2025
@psrvere psrvere marked this pull request as ready for review March 6, 2025 08:11
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 6, 2025
@SaschaSchwarze0
Copy link
Member

SaschaSchwarze0 commented Mar 6, 2025

@psrvere please make sure to sign the commits.

I also expect things to not compile because you did not change the Go version in the GitHub actions. But we will see when they run.

@psrvere psrvere closed this Mar 6, 2025
@psrvere psrvere deleted the source/release-v0.14 branch March 6, 2025 09:12
@psrvere
Copy link
Author

psrvere commented Mar 6, 2025

Sure @SaschaSchwarze0. Let me raise another PR with signed commits. Also, will check for Github actions.

@SaschaSchwarze0
Copy link
Member

Sure @SaschaSchwarze0. Let me raise another PR with signed commits. Also, will check for Github actions.

Oh, you could have easily signed the commits on this PR.

@psrvere
Copy link
Author

psrvere commented Mar 6, 2025

Yes I figured but I had deleted the remote branch by then 🤦‍♂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/dependency-change Categorizes issue or PR as related to changing dependencies release-note Label for when a PR has specified a release note size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants