Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run e2e Go tests first. #462

Merged
merged 1 commit into from
Mar 4, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Run e2e Go tests first.
I suspect why the e2e tests are failing is because we're running this
after the staging tests when the sigstore root has been changed to
staging.

Current the tests hardcode prod sigstore, which is likely what is causing the issues
since we're trying to verify a prod signature with the staging root.
TBD if this is the right thing to do (or if we should use staging instead),
but this should hopefully fix us for the time being.
wlynch committed Mar 4, 2024

Unverified

The signing certificate or its chain could not be verified.
commit 9166fff340070070d51db0e2ec63b6d66fa5e890
10 changes: 5 additions & 5 deletions .github/workflows/e2e.yaml
Original file line number Diff line number Diff line change
@@ -53,6 +53,11 @@ jobs:
go-version: "1.21"
check-latest: true

- name: e2e unit tests
run: |
set -e
make e2e-test

- name: Install Gitsign
run: |
set -e
@@ -148,8 +153,3 @@ jobs:
- name: Debug log
if: failure()
run: cat "${GITSIGN_LOG}"

- name: e2e unit tests
run: |
set -e
make e2e-test