Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support gitsign-credential-cache on Windows #579

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

adityasaky
Copy link
Member

Summary

This PR adds support for Windows to gitsign-credential-cache. Fixes #497

Release Note

Added support for Windows to gitsign-credential-cache

Documentation

NONE

@adityasaky
Copy link
Member Author

I haven't had a chance to check this on my Windows machine yet. A relevant discussion as an alternative to syscall.Umask: golang/go#11822

Also, I'm not sure of the impact of taking out the Umask call on the systemd flow, should we Umask there? I think that should be managed by systemd for us but I'm unsure. We can at least be sure Umask is supported anywhere systemd is used.

Unverified

This user has not yet uploaded their public signing key.
Signed-off-by: Aditya Sirish A Yelgundhalli <ayelgundhall@bloomberg.net>
@adityasaky adityasaky force-pushed the credential-helper-windows branch from 8bd32c5 to 9549acd Compare October 18, 2024 20:43
@adityasaky
Copy link
Member Author

adityasaky commented Oct 18, 2024

I can confirm this works on Windows!

<REDACTED> MINGW64 ~/repos/sigstore/test-credential-cache (master)
$ git commit -m "Commit" --allow-empty -S
Get <REDACTED>@C:\Users\ayelgundhall\repos\sigstore\test-credential-cache
no cred found, going through intereractive flow...
Your browser will now be opened to:
https://oauth2.sigstore.dev/auth/auth?access_type=online&client_id=sigstore&code_challenge=hkhZdRxJAE5WsMwoJ1nt7OJx6xQ9Kz_ULpwgNI5Woho&code_challenge_method=S256&nonce=2nd6hUHLYFqvq5xElM13Ax1I13s&redirect_uri=http%3A%2F%2Flocalhost%3A60351%2Fauth%2Fcallback&response_type=code&scope=openid+email&state=2nd6hTGU7g4VOsBWN1QyxSvjcVy
tlog entry created with index: 141501326
[master 559402a] Commit

<REDACTED> MINGW64 ~/repos/sigstore/test-credential-cache (master)
$ git commit -m "Commit" --allow-empty -S
Get <REDACTED>@C:\Users\ayelgundhall\repos\sigstore\test-credential-cache
found cred!
tlog entry created with index: 141501336
[master 7002f5d] Commit

(I can sneak in a fix for the typo)

@adityasaky adityasaky requested a review from wlynch October 21, 2024 14:27
@adityasaky adityasaky marked this pull request as ready for review October 21, 2024 16:26
@adityasaky adityasaky merged commit 51907a6 into sigstore:main Oct 21, 2024
7 checks passed
@adityasaky adityasaky deleted the credential-helper-windows branch October 21, 2024 16:26
@adityasaky
Copy link
Member Author

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cache option for Windows
2 participants